Inferencing type reference of abstract class inferred from concrete type values#8096
Merged
ilevkivskyi merged 4 commits intopython:masterfrom Dec 7, 2019
TH3CHARLie:fix-8050
Merged
Inferencing type reference of abstract class inferred from concrete type values#8096ilevkivskyi merged 4 commits intopython:masterfrom TH3CHARLie:fix-8050
ilevkivskyi merged 4 commits intopython:masterfrom
TH3CHARLie:fix-8050
Conversation
JukkaL
approved these changes
Dec 6, 2019
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks, looks good! I checked that this doesn't generate new errors in our internal codebase S.
@ilevkivskyi Do you want to have a look since you proposed this change?
ilevkivskyi
approved these changes
Dec 6, 2019
Member
ilevkivskyi
left a comment
ilevkivskyi
left a comment
There was a problem hiding this comment.
Looks good, but I have a suggestion about the comments.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #8050, following the purposed solution 2 in #8050 (comment) and using the implementation purposed in #8050 (comment)
Currently, no testcase with regard to meet of callables is available, since I'm not sure what a proper testcase would be.