Repository navigation
Conversation
untitaker
commented
Jun 24, 2019
|
|
||
|
|
||
| def expand_formal_type(formal_type: Type, actual_name: Optional[str], tuple_idx: int) -> Type: | ||
| if isinstance(formal_type, Instance) and formal_type.type.fullname() == 'mypy_extensions.Expand': |
Author
There was a problem hiding this comment.
This is ugly. How do I get something like TypedDictType (ExpandType) and make mypy map mypy_extensions.Expand to mypy.types.ExpandType?
Member
|
Thanks for PR! I think it should be done in a different way: it will be simpler if most of things happen during semantic analysis rather than type checking. Note that we currently have two semantic analyzers (things that construct symbol tables and bind reference expressions to symbols). The old one will be deprecated soon, so I propose to only support this with the new one (located in
Let me know if you have more questions. |
Author
|
I think I don't have the motivation to work on this anymore, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements
Expandin kwarg positions as per #4441. TODO:Expandoutside of*argsand**kwargs(what doesx: Expand[...] = 42even mean?)Expandproperly s.t one can import it at runtimeRight now this PR only exists as a discussion basis for the approach I should take when implementing this properly. Adding
expand_formal_typeseems to be the best way to me right now but I don't have good oversight over the entire codebase to know any better.