Suppress errors for unreachable branches in conditional expressions#18295
Merged
JukkaL merged 1 commit intopython:masterfrom Dec 20, 2024
Merged
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: prefect (https://github.com/PrefectHQ/prefect)
- src/prefect/_internal/concurrency/cancellation.py:240: error: Unsupported operand types for - ("float" and "None") [operator]
vision (https://github.com/pytorch/vision)
+ torchvision/transforms/v2/functional/_geometry.py:628: error: Unused "type: ignore" comment [unused-ignore]
jax (https://github.com/google/jax)
+ jax/_src/numpy/linalg.py:393: error: Unused "type: ignore" comment [unused-ignore]
+ jax/_src/export/shape_poly.py:1642: error: Unused "type: ignore" comment [unused-ignore]
+ jax/_src/export/shape_poly.py:1661: error: Unused "type: ignore" comment [unused-ignore]
graphql-core (https://github.com/graphql-python/graphql-core)
+ src/graphql/type/definition.py:793: error: Unused "type: ignore" comment [unused-ignore]
+ src/graphql/type/definition.py:898: error: Unused "type: ignore" comment [unused-ignore]
+ src/graphql/type/definition.py:1365: error: Unused "type: ignore" comment [unused-ignore]
|
JukkaL
approved these changes
Dec 20, 2024
Collaborator
JukkaL
left a comment
There was a problem hiding this comment.
Nice, thanks for the fix!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4134
Fixes #9195
Suppress errors when analyzing unreachable conditional expression branches. Same idea as what's done when analyzing the right-hand operand of
and/or:mypy/mypy/checkexpr.py
Lines 4252 to 4256 in 973618a
This PR originally added filters of the same form to the places where
analyze_cond_branchis called inExpressionChecker.visit_conditional_expr. However, since 5 out of the 6analyze_cond_branchcall sites now usefilter_errorsfor the case whenmap is None, I decided to move the error filtering logic to insideanalyze_cond_branch.Given:
Before:
After: