Revert "stubtest pos-only differences in dunders (#12184)"#12293
Revert "stubtest pos-only differences in dunders (#12184)"#12293hauntsaninja merged 1 commit intopython:masterfrom
Conversation
…thon#12184)" This reverts commit 777885f.
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
JelleZijlstra
left a comment
There was a problem hiding this comment.
Always glad when mypy-primer confirms that changing stubtest doesn't affect typechecking output.
Though maybe we need a stubtest-primer that tells us stubtest's output on all of typeshed's third-party stubs.
AlexWaygood
left a comment
There was a problem hiding this comment.
Thanks! I agree this was the way to go :)
Yes, I think this would be very helpful. Something similar to the "Daily test" job in the typeshed CI, that's run on every stubtest PR, would be amazing. (Edit: it would obviously have to be done in a non-blocking way, like mypy_primer.) |
This reverts commit 777885f.
To help with python/typeshed#7441 and reduce risk of stubtest issues interfering with a mypy release. The extra type correctness here is really minimal.