Replace deprecated workflow with RtD app#1713
Conversation
|
@hugovk done |
|
Thanks! I opened #1714 to test, but it doesn't seem to have triggered. At least I can see it's installed on this repo:
Will check tomorrow. |
|
Right, figured it out on my fork: hugovk#37 @Mariatta Please could you add Then I can complete the migration to the app and then check "Show build overview in a comment" at https://app.readthedocs.org/dashboard/cpython-devguide/pull-requests/ |
|
@brettcannon Or please could you do the above to add me? #1713 (comment) |
Invite sent! |
|
Thanks, accepted! I don't see the migration option for this repo, I think it needs someone with admin access to the repo as well. I've added @JacobCoffee to RtD and will talk with him to get it set up. |
|
Thanks @JacobCoffee! A |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
I've just checked "Show build overview in a comment" at https://app.readthedocs.org/dashboard/cpython-devguide/pull-requests/
And we now have a comment at #1714 (comment) 🚀 |
Documentation build overview
Show files changed (1 files in total): 📝 1 modified | ➕ 0 added | ➖ 0 deleted
|
|
Thanks all! The comment is a little more verbose than before, but better to improve our security (& it does provide more info!). A |



For python/core-workflow#587.
This workflow is deprecated, and uses the
pull_request_targettarget which can be insecure.Let's test replacing it with the Read the Docs app. If it goes well, we can replace it in the other repos.
@python/organization-owners I've sent a request to install the RtD app for just this repo, please could you enable it?
📚 Documentation preview 📚: https://cpython-devguide--1713.org.readthedocs.build/