Skip to content

gh-98713: Use @cpython_only for a test that fails on PyPy#98714

Merged
AlexWaygood merged 3 commits intopython:mainfrom
sobolevn:issue-98713
Oct 26, 2022
Merged

gh-98713: Use @cpython_only for a test that fails on PyPy#98714
AlexWaygood merged 3 commits intopython:mainfrom
sobolevn:issue-98713

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 26, 2022 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Oct 26, 2022
AlexWaygood
AlexWaygood reviewed Oct 26, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we maybe add a short news entry? The test made it into 3.11.0.

Otherwise this looks good! You beat the PR I was writing to the finish line ;)

@sobolevn
Copy link
Member Author

sobolevn commented Oct 26, 2022

I've never seen a NEWS entry for tests. If others say so - I surely will add it.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 26, 2022

We usually skip news for PRs that improve test coverage etc, but this is fixing a bug in the test suite that existed in a previous release of Python, so I'd argue for including a short news entry.

AlexWaygood
AlexWaygood approved these changes Oct 26, 2022
View reviewed changes
@sobolevn @AlexWaygood
Update Misc/NEWS.d/next/Tests/2022-10-26-15-19-20.gh-issue-98713.Lnu3…
909a888 
…2R.rst

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@miss-islington
Copy link
Contributor

miss-islington commented Oct 26, 2022

@sobolevn: Status check is done, and it's a failure or timed out ❌.

@AlexWaygood
Copy link
Member

AlexWaygood commented Oct 26, 2022

The test_asyncio failure is unrelated and will be fixed by #98704.

@AlexWaygood AlexWaygood merged commit 9495360 into python:main Oct 26, 2022
@miss-islington
Copy link
Contributor

miss-islington commented Oct 26, 2022

Thanks @sobolevn for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

bedevere-bot commented Oct 26, 2022

GH-98717 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 26, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 26, 2022
@sobolevn @miss-islington
pythongh-98713: Use @cpython_only for a test that fails on PyPy (py…
507d211 
…thonGH-98714)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 9495360)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 26, 2022
@miss-islington @sobolevn
gh-98713: Use @cpython_only for a test that fails on PyPy (GH-98714)
ce2b56e 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 9495360)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@AlexWaygood AlexWaygood AlexWaygood approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees

No one assigned

Labels

tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@sobolevn @AlexWaygood @miss-islington @bedevere-bot @kumaraditya303