gh-97922: Run the GC only on eval breaker#97920
Merged
pablogsal merged 7 commits intopython:mainfrom Oct 8, 2022
Merged
Conversation
pablogsal
changed the title
pablogsal
changed the title
arhadthedev
requested changes
Oct 5, 2022
Misc/NEWS.d/next/Core and Builtins/2022-10-05-11-37-15.gh-issue-97922.Zu9Bge.rst
Outdated
Show resolved
Hide resolved
pablogsal
force-pushed
the
gc_scheduled
branch
3 times, most recently
from
5951465 to
1634d14
Compare
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 1634d14 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Member
|
Looks good, but let's run the buildbots before merging. |
Signed-off-by: Pablo Galindo <[email protected]>
pablogsal
force-pushed
the
gc_scheduled
branch
from
1634d14 to
52f3855
Compare
Member
|
This fixes the new test: diff --git a/Lib/test/test_frame.py b/Lib/test/test_frame.py
index 4b86a60d2f..4b5bb7f94a 100644
--- a/Lib/test/test_frame.py
+++ b/Lib/test/test_frame.py
@@ -277,7 +277,7 @@ def callback(phase, info):
frame!
"""
nonlocal sneaky_frame_object
- sneaky_frame_object = sys._getframe().f_back
+ sneaky_frame_object = sys._getframe().f_back.f_back
# We're done here:
gc.callbacks.remove(callback) |
brandtbucher
approved these changes
Oct 7, 2022
Member
brandtbucher
left a comment
brandtbucher
left a comment
There was a problem hiding this comment.
Looks mostly good! Just a couple of questions regarding eval breaker recomputation.
Also, would it be better to run the GC after signals, etc.? I would guess that prompt signal handling, etc. would be more important than prompt GC. I have a slight preference towards preserving the current behavior for when signals, etc. are handled and just moving the GC around, rather than potentially changing when everything else is handled too.
Co-authored-by: Brandt Bucher <[email protected]>
Member
Author
Indeed, it makes sense. I moved it after signals and pending calls but before gil switching |
Co-authored-by: Brandt Bucher <[email protected]>
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 8, 2022
* main: pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184)
carljm
added a commit
to carljm/cpython
that referenced
this pull request
Oct 9, 2022
* main: (5519 commits) Minor edits to the Descriptor HowTo Guide (pythonGH-24901) Fix link to Lifecycle of a Pull Request in CONTRIBUTING (python#98102) pythonGH-94597: deprecate `SafeChildWatcher`, `FastChildWatcher` and `MultiLoopChildWatcher` child watchers (python#98089) Auto-cancel old builds when new commit pushed to branch (python#98009) pythongh-95011: Migrate syslog module to Argument Clinic (pythonGH-95012) pythongh-68686: Retire eptag ptag scripts (python#98064) pythongh-97922: Run the GC only on eval breaker (python#97920) GitHub Workflows security hardening (python#96492) Add `@ezio-melotti` as codeowner for `.github/`. (python#98079) pythongh-97913 Docs: Add walrus operator to the index (python#97921) [doc] Fix broken links to C extensions accelerating stdlib modules (python#96914) pythongh-97822: Fix http.server documentation reference to test() function (python#98027) pythongh-91052: Add PyDict_Unwatch for unwatching a dictionary (python#98055) pythonGH-98023: Change default child watcher to PidfdChildWatcher on supported systems (python#98024) pythonGH-94182: Run the PidfdChildWatcher on the running loop (python#94184) pythongh-92886: make test_ast pass with -O (assertions off) (pythonGH-98058) pythongh-92886: make test_coroutines pass with -O (assertions off) (pythonGH-98060) pythongh-57179: Add note on symlinks for os.walk (python#94799) pythongh-94808: Fix regex on exotic platforms (python#98036) pythongh-90085: Remove vestigial -t and -c timeit options (python#94941) ...
mpage
pushed a commit
to mpage/cpython
that referenced
this pull request
Oct 11, 2022
This was referenced Dec 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.