gh-96175: add missing self._localName assignment in `xml.dom.minidom.Attr` by kkirsche · Pull Request #96176 · python/cpython

kkirsche · 2022-08-22T14:25:53Z

Fixes: #96175

X-Ref: python/typeshed#8590 (comment)

This adds a missing assignment to _localName

Issue: xml.dom.minidom:Attr.__init__ doesn't use localName variable. #96175

X-Ref: python/typeshed#8590 (comment) This adds a missing assignment to `_localName`

bedevere-bot · 2022-08-22T14:25:56Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

ghost · 2022-08-22T14:26:19Z

All commit authors signed the Contributor License Agreement.

kkirsche · 2022-08-22T14:28:32Z

CLA stuff is borked:

JelleZijlstra · 2022-08-22T14:34:59Z

Thank you!

cc @ambv for the CLA bot throwing a 500.

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 at https://devguide.python.org/?highlight=blurb#quick-reference.

kkirsche · 2022-08-22T17:32:19Z

Could you add a unit test and a NEWS entry? You can use blurb as documented under 8 at https://devguide.python.org/?highlight=blurb#quick-reference.

I'll give it my best shot, I have that cloning so I can add those in after my next meeting this afternoon. Thanks for the opportunity to contribute this to cpython, it's a project where the must have an issue requirement in the contributing guide has kept me away in the past.

bedevere-bot · 2022-08-22T17:50:27Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

bedevere-bot · 2022-08-22T17:50:33Z

Most changes to Python require a NEWS entry.

Please add it using the blurb_it web app or the blurb command-line tool.

kkirsche · 2022-08-22T17:55:34Z

I've added my attempt at this. If I did anything incorrectly or without enough detail, please let me know.

It may also be useful to give an example in blurb about what a good paragraph would look like.

kkirsche · 2022-08-22T20:21:44Z

I have tried to sign the CLA, but have been unable to. Sometimes it shows up as signed, other times it doesn't, so wanted to comment here explicitly.

JelleZijlstra · 2022-08-22T20:54:51Z

The CLA actually seems fine, the check in CI is succeeding.

Lib/test/test_minidom.py

Misc/NEWS.d/next/Library/2022-08-22-13-54-20.gh-issue-96175.bH7zGU.rst

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Lib/test/test_minidom.py

miss-islington · 2022-08-23T16:16:05Z

Thanks @kkirsche for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

miss-islington · 2022-08-23T16:16:07Z

Sorry @kkirsche and @JelleZijlstra, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 58f6953d6d3fe20d972bfa2f6e982206adcf1353 3.11

JelleZijlstra · 2022-08-23T16:16:13Z

Thank you for your contribution!

…nidom.Attr` (pythonGH-96176) X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977 Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 58f6953) Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>

bedevere-bot · 2022-08-23T16:16:16Z

GH-96212 is a backport of this pull request to the 3.10 branch.

miss-islington · 2022-08-23T16:16:33Z

Thanks @kkirsche for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

bedevere-bot · 2022-08-23T16:16:41Z

GH-96213 is a backport of this pull request to the 3.11 branch.

…nidom.Attr` (pythonGH-96176) X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977 Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 58f6953) Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>

…Attr` (GH-96176) X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977 Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 58f6953) Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>

kkirsche · 2022-08-23T16:57:12Z

Thank you for your contribution!

Thank you for your time reviewing this and your patience explaining why decisions are being made as I learn more about CPython.

…Attr` (GH-96176) X-Ref: https://github.com/python/typeshed/pull/8590GH-discussion_r951473977 Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com> (cherry picked from commit 58f6953) Co-authored-by: Kevin Kirsche <Kev.Kirsche+GitHub@gmail.com>

…nidom.Attr` (python#96176) X-Ref: python/typeshed#8590 (comment) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Fix: add missing self._localName assignment in xml.dom.minidom.Attr

9cb30d5

X-Ref: python/typeshed#8590 (comment) This adds a missing assignment to `_localName`

bedevere-bot added the awaiting review label Aug 22, 2022

kkirsche mentioned this pull request Aug 22, 2022

refactor: expand types in xml module python/typeshed#8590

Merged

JelleZijlstra self-assigned this Aug 22, 2022

JelleZijlstra added needs backport to 3.10 only security fixes needs backport to 3.11 only security fixes labels Aug 22, 2022

Kevin Kirsche added 2 commits August 22, 2022 13:50

fix: add missing unit test

70a82e1

fix: add missing import

c97a7fa

fix: add blurb

fb8c871

fix: use of default role in rst

d2eec57

JelleZijlstra reviewed Aug 23, 2022

View reviewed changes

Lib/test/test_minidom.py Outdated Show resolved Hide resolved

Lib/test/test_minidom.py Outdated Show resolved Hide resolved

Misc/NEWS.d/next/Library/2022-08-22-13-54-20.gh-issue-96175.bH7zGU.rst Outdated Show resolved Hide resolved

kkirsche and others added 3 commits August 22, 2022 20:34

Use requested NEWS format

fcbe67a

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

fix: remove undesired unit test error messages

dee21ce

use Jelles preferred testing style

8910ca9

JelleZijlstra reviewed Aug 23, 2022

View reviewed changes

Lib/test/test_minidom.py Outdated Show resolved Hide resolved

Kevin Kirsche and others added 2 commits August 23, 2022 07:36

refactor: update tests to verify that _get_name falls back to qName

19fbcc4

Merge branch 'main' into patch-2

93e41d1

JelleZijlstra approved these changes Aug 23, 2022

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Aug 23, 2022

JelleZijlstra merged commit 58f6953 into python:main Aug 23, 2022

bedevere-bot removed the awaiting merge label Aug 23, 2022

bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 23, 2022

JelleZijlstra added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Aug 23, 2022

bedevere-bot removed the needs backport to 3.11 only security fixes label Aug 23, 2022

kkirsche deleted the patch-2 branch August 23, 2022 18:25

mdboom pushed a commit to mdboom/cpython that referenced this pull request Aug 24, 2022

pythongh-96175: add missing self._localName assignment in `xml.dom.mi…

77c8ccc

…nidom.Attr` (python#96176) X-Ref: python/typeshed#8590 (comment) Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>

Uh oh!

Conversation

kkirsche commented Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

bedevere-bot commented Aug 22, 2022

Uh oh!

ghost commented Aug 22, 2022 • edited by ghost Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

kkirsche commented Aug 22, 2022

Uh oh!

JelleZijlstra commented Aug 22, 2022

Uh oh!

kkirsche commented Aug 22, 2022

Uh oh!

bedevere-bot commented Aug 22, 2022

Uh oh!

bedevere-bot commented Aug 22, 2022

Uh oh!

kkirsche commented Aug 22, 2022

Uh oh!

kkirsche commented Aug 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JelleZijlstra commented Aug 22, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

miss-islington commented Aug 23, 2022

Uh oh!

miss-islington commented Aug 23, 2022

Uh oh!

JelleZijlstra commented Aug 23, 2022

Uh oh!

bedevere-bot commented Aug 23, 2022

Uh oh!

miss-islington commented Aug 23, 2022

Uh oh!

bedevere-bot commented Aug 23, 2022

Uh oh!

kkirsche commented Aug 23, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

kkirsche commented Aug 22, 2022 •

edited

Loading

ghost commented Aug 22, 2022 •

edited by ghost

Loading

kkirsche commented Aug 22, 2022 •

edited

Loading