bpo-46315: Use fopencookie() to avoid dup() in _PyTokenizer_FindEncodingFilename#32033
bpo-46315: Use fopencookie() to avoid dup() in _PyTokenizer_FindEncodingFilename#32033tiran merged 4 commits intopython:mainfrom
Conversation
pablogsal
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @pablogsal for commit 6be12fc 🤖 If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
Parser/tokenizer.c
Outdated
| // cookie is just the fd | ||
| borrowed b; | ||
| b.fd = fd; | ||
| return fopencookie(b.cookie, "r", cookie_io); |
There was a problem hiding this comment.
fopencookie is a non-standard GNU extension. Is this available in all platforms targetted by web assembly? Does this need a configure check?
There was a problem hiding this comment.
I had a configure check in my first version of the patch. I got rid of it because it makes no sense. Both WASI and Emscripten use musl libc as upper half of libc and it always provides fdopencookie.
I wish their was a more elegant way to solve the problem. _PyTokenizer_FindEncodingFilename uses a FILE pointer instead of a file descriptor.
There was a problem hiding this comment.
Ugh, I am honestly not very happy with the amount of extra code, but I understand why is needed.
|
The failing tests on macOS ARM64 and FreeBSD are unrelated to my changes. |
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
The code looks good to me, but I had no way to test it myself, so I am not formally approving. Feel free to land if you want though
Misc/NEWS.d/next/Core and Builtins/2022-03-21-20-05-10.bpo-46315.2QqFIC.rst
Outdated
Show resolved
Hide resolved
tiran
changed the title
|
I can shorten the code. |
4 participants
https://bugs.python.org/issue46315