bpo-47062: Implement asyncio.Runner context manager#31799
Merged
Conversation
zware
reviewed
Mar 18, 2022
Member
zware
left a comment
There was a problem hiding this comment.
I have a few mostly grammatical suggestions, but otherwise LGTM.
There may be a few comments that no longer apply; I started reviewing before you finished pushing changes and now I can't find them to remove them :)
Co-authored-by: Zachary Ware <zach@python.org>
Co-authored-by: Zachary Ware <zach@python.org>
Co-authored-by: Zachary Ware <zach@python.org>
Contributor
Author
|
Thanks, @zware |
zware
approved these changes
Mar 21, 2022
1st1
reviewed
Mar 21, 2022
1st1
reviewed
Mar 21, 2022
1st1
reviewed
Mar 21, 2022
Contributor
Author
|
I've modified the Runner class to use lazy initialization: @1st1 does it look better for you? |
Contributor
Author
|
Explicit |
Member
|
Post merge: can you rename "factory" to "loop_factory"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue47062