Skip to content

bpo-46586: Fix more erroneous doc links to builtins#31429

Merged
JelleZijlstra merged 8 commits intopython:mainfrom
meersuri:fix-issue-46586
May 2, 2022
Merged

bpo-46586: Fix more erroneous doc links to builtins#31429
JelleZijlstra merged 8 commits intopython:mainfrom
meersuri:fix-issue-46586

Conversation

@meersuri
Copy link
Contributor

@meersuri meersuri commented Feb 19, 2022 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Feb 19, 2022
@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 19, 2022

Hi, it looks like you need to merge origin/main into your branch here — the enum.property fix is still showing up in this PR, even though that one's already been committed to main 🙂

merwok
merwok reviewed Mar 5, 2022
View reviewed changes
merwok
merwok reviewed Mar 5, 2022
View reviewed changes
JelleZijlstra
JelleZijlstra reviewed May 2, 2022
View reviewed changes
@JelleZijlstra @merwok
Apply suggestions from code review
ccf9af7 
Co-authored-by: Éric <merwok@netwok.org>
@JelleZijlstra JelleZijlstra self-assigned this May 2, 2022
merwok
merwok reviewed May 2, 2022
View reviewed changes
merwok
merwok reviewed May 2, 2022
View reviewed changes
@JelleZijlstra @merwok
Apply suggestions from code review
5d0aad4 
Co-authored-by: Éric <merwok@netwok.org>
@merwok
Copy link
Member

merwok commented May 2, 2022 •
edited
Loading

Thanks for this PR!
Could we also fix the wrong markup in the documentation of structseq objects? (see #90744 (comment))

@JelleZijlstra
Copy link
Member

JelleZijlstra commented May 2, 2022

@merwok let's keep that for another PR, so we can land this one.

@merwok
Copy link
Member

merwok commented May 2, 2022

I don’t really get why split these fixes into three changes here, two changes there (and the original ticket about enum has already had its scope widered), but 🤷🏽 it’s up to you! Better to merge some fixes than none 🙂

@JelleZijlstra JelleZijlstra merged commit cc6ae4f into python:main May 2, 2022
@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Thanks @meersuri for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request May 2, 2022
@meersuri @miss-islington
bpo-46586: Fix more erroneous doc links to builtins (pythonGH-31429)
3445252 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@miss-islington
Copy link
Contributor

miss-islington commented May 2, 2022

Sorry, @meersuri and @JelleZijlstra, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker cc6ae4f4835f9e76a34f24cd1f666c1cc0fecfa3 3.9

@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

GH-92198 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label May 2, 2022
JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request May 2, 2022
@meersuri @JelleZijlstra
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
0ccd7f2 
…1429)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@bedevere-bot
Copy link

bedevere-bot commented May 2, 2022

GH-92199 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request May 2, 2022
@miss-islington @meersuri
bpo-46586: Fix more erroneous doc links to builtins (GH-31429)
5f40cb8 
Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
JelleZijlstra added a commit that referenced this pull request May 3, 2022
@JelleZijlstra @meersuri
[3.9] bpo-46586: Fix more erroneous doc links to builtins (GH-31429) (#…
92d2615 
…92199)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
hello-adam pushed a commit to hello-adam/cpython that referenced this pull request Jun 2, 2022
@JelleZijlstra @meersuri @hello-adam
[3.9] bpo-46586: Fix more erroneous doc links to builtins (pythonGH-3…
a527fa6 
…1429) (python#92199)

Co-authored-by: Jelle Zijlstra <jelle.zijlstra@gmail.com>
Co-authored-by: Éric <merwok@netwok.org>.
(cherry picked from commit cc6ae4f)

Co-authored-by: Meer Suri <46469858+meersuri@users.noreply.github.com>
@Dutcho Dutcho mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes

@AlexWaygood AlexWaygood AlexWaygood left review comments

@ethanfurman ethanfurman Awaiting requested review from ethanfurman

Assignees

@JelleZijlstra JelleZijlstra

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@meersuri @AlexWaygood @merwok @JelleZijlstra @miss-islington @bedevere-bot @hugovk @the-knights-who-say-ni