bpo-46430: Intern strings in deep-frozen modules #30683
Merged
gvanrossum merged 6 commits intopython:mainfrom Feb 9, 2022
Merged
bpo-46430: Intern strings in deep-frozen modules #30683gvanrossum merged 6 commits intopython:mainfrom
gvanrossum merged 6 commits intopython:mainfrom
Conversation
gvanrossum
reviewed
Jan 19, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
I have a feeling this isn't going to be enough, alas. :-(
I've tried to drop a few hints in the review. :-)
Contributor
Author
|
I'll revisit this once statically allocated strings land by @ericsnowcurrently See #30928 |
Member
To be clear you're referencing faster-cpython/ideas#230 and #30928 here. |
kumaraditya303
force-pushed
the
intern
branch
from
198a965 to
b2d3eb2
Compare
gvanrossum
approved these changes
Feb 7, 2022
Member
gvanrossum
left a comment
gvanrossum
left a comment
There was a problem hiding this comment.
Nice, I just think we shouldn't ignore errors.
methane
approved these changes
Feb 9, 2022
Member
|
The change introduced a regression: https://bugs.python.org/issue46430#msg413822 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46430