Skip to content

bpo-46184: remove netlify.toml#30272

Merged
Mariatta merged 4 commits intopython:mainfrom
sobolevn:issue-46184
Dec 30, 2021
Merged

bpo-46184: remove netlify.toml#30272
Mariatta merged 4 commits intopython:mainfrom
sobolevn:issue-46184

Conversation

@sobolevn
Copy link
Member

@sobolevn sobolevn commented Dec 26, 2021 •
edited by bedevere-bot
Loading

Related to #30257

I guess we can skip NEWS on this one.

https://bugs.python.org/issue46184

@sobolevn sobolevn closed this Dec 27, 2021
@sobolevn sobolevn reopened this Dec 27, 2021
@sobolevn
Copy link
Member Author

sobolevn commented Dec 27, 2021

Windows build for winarm take a lot of time, then it is canceled. https://dev.azure.com/Python/cpython/_build/results?buildId=93679&view=logs&j=91c152bd-7320-5194-b252-1404e56e2478

This failure does not seem related.

kumaraditya303
kumaraditya303 approved these changes Dec 27, 2021
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as it seems unused.

@hugovk
Copy link
Member

hugovk commented Dec 28, 2021 •
edited
Loading

This file was added in #15288 / https://bugs.python.org/issue37860 but Netlify wasn't turned on due to build limits:

#15288 (comment)

I guess that was never resolved, so okay to remove this file, @epicfaace?

If so, should also remove Doc/runtime.txt, added for Netlify in the same PR.

And see #19025 for an open, alternate approach using GitHub Actions.

hugovk
hugovk reviewed Dec 28, 2021
View reviewed changes
Doc/requirements.txt
@@ -1,12 +0,0 @@
# Requirements to build the Python documentation
Copy link
Member

@hugovk hugovk Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doc/requirements.txt is still needed:

https://github.com/python/cpython/runs/4649987492?check_suite_focus=true#step:7:30

Copy link
Member Author

@sobolevn sobolevn Dec 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hugovk thank you! 👍

@sobolevn
Copy link
Member Author

sobolevn commented Dec 28, 2021

@AlexWaygood do you think that this can be marked as "skip news"?

@AlexWaygood
Copy link
Member

AlexWaygood commented Dec 28, 2021

@AlexWaygood do you think that this can be marked as "skip news"?

Okay, I am adding the skip-news label, as it seems appropriate to me. But, this is not something I really know anything about, so anybody who thinks that this needs a news entry should feel free to remove it again. 🙂

@sobolevn
Copy link
Member Author

sobolevn commented Dec 30, 2021

@Mariatta are you the right person to ping in this case? 🙂

Mariatta
Mariatta approved these changes Dec 30, 2021
View reviewed changes
Copy link
Member

@Mariatta Mariatta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning these up.

@Mariatta Mariatta merged commit fbaf2e6 into python:main Dec 30, 2021
@bedevere-bot
Copy link

bedevere-bot commented Dec 30, 2021

@Mariatta: Please replace # with GH- in the commit message next time. Thanks!

@sobolevn sobolevn mentioned this pull request Jan 2, 2022
Closed
ewdurbin pushed a commit that referenced this pull request Dec 6, 2022
@hugovk
bpo-37860: re-add netlify.toml to set up deploy previews for docs (#9…
85d5a7e 
…2852)

* Revert "bpo-46184: remove `netlify.toml` (#30272)"

This reverts commit fbaf2e6.

* Delete runtime.txt

* Create runtime.txt

* Delete runtime.txt

* Update netlify.toml

* Update netlify.toml

* Add netlify badge

* Update Doc/tools/templates/layout.html

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>

* Update layout.html

Co-authored-by: Hugo van Kemenade <hugovk@users.noreply.github.com>
aryautkarsh091 added a commit to aryautkarsh091/astropy that referenced this pull request Jan 18, 2026
@aryautkarsh091
Fix minversion TypeError with dev version strings
1251baa 
Switch to packaging.version.Version for version comparison
to handle PEP 440 dev/rc versions correctly. This resolves
failures introduced by PR astropy#7647 and avoids distutils'
LooseVersion bug (see python/cpython#30272).

Add tests for dev/rc version handling in minversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hugovk hugovk hugovk left review comments

@Mariatta Mariatta Mariatta approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@sobolevn @hugovk @AlexWaygood @bedevere-bot @Mariatta @kumaraditya303 @the-knights-who-say-ni