bpo-19561: Remove unnecessary gethostname() prototype for Solaris#23208
Closed
kulikjak wants to merge 1 commit intopython:mainfrom
Closed
bpo-19561: Remove unnecessary gethostname() prototype for Solaris#23208kulikjak wants to merge 1 commit intopython:mainfrom
kulikjak wants to merge 1 commit intopython:mainfrom
Conversation
jstasiak
approved these changes
Nov 12, 2020
Contributor
jstasiak
left a comment
jstasiak
left a comment
There was a problem hiding this comment.
Just tested this on OpenIndiana, works fine.
|
This PR is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 5 days |
Contributor
Author
|
I cannot remove the |
github-actions
bot
removed
the
stale
|
This PR is stale because it has been open for 30 days with no activity. |
Contributor
Author
|
Still relevant... |
github-actions
bot
removed
the
stale
kulikjak
force-pushed
the
fix-gethostname-declaration
branch
3 times, most recently
from
3f551bd to
d650b0c
Compare
Member
|
@jcea (as an OpenSolaris expert) |
kulikjak
force-pushed
the
fix-gethostname-declaration
branch
from
cb868a7 to
93e64c8
Compare
kulikjak
force-pushed
the
fix-gethostname-declaration
branch
from
93e64c8 to
d2fc237
Compare
Member
|
I proposed PR #108817 with more details on the issue. |
Contributor
Author
|
Fixed with #108817. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is no longer necessary because Solaris included
gethostname()in its header files more than 15 years ago.https://bugs.python.org/issue19561