Skip to content

bpo-40968: Send http/1.1 ALPN extension#20959

Merged
tiran merged 1 commit intopython:masterfrom
tiran:bpo-40968-alpn
Nov 13, 2020
Merged

bpo-40968: Send http/1.1 ALPN extension#20959
tiran merged 1 commit intopython:masterfrom
tiran:bpo-40968-alpn

Conversation

@tiran
Copy link
Member

@tiran tiran commented Jun 18, 2020 •
edited by bedevere-bot
Loading

@tiran tiran added type-bug An unexpected behavior, bug, or error needs backport to 3.7 labels Jun 18, 2020
@tiran
Copy link
Member Author

tiran commented Jun 18, 2020

  • It's a low-risk change. cURL has been setting the ALPN indicator for years.
  • The change fixes a problem with servers that require an ALPN extension to indicate HTTP version.
  • Need to figure out how to test the change.

@paulmenzel paulmenzel mentioned this pull request Jun 18, 2020
Closed
@tiran tiran mentioned this pull request Jun 18, 2020
Closed
sethmlarson
sethmlarson reviewed Jun 18, 2020
View reviewed changes
Lib/http/client.py Outdated
Copy link
Contributor

@sethmlarson sethmlarson Jun 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are this comment and the functionality out of sync here since http_vsn_str can be HTTP/1.0, etc? http/1.1, http/1.0, and http/0.9 are all valid ALPN protocol IDs but the comment and changelogs only mention 1.1. This might be fine anyways but something I noticed.

Copy link
Member Author

@tiran tiran Nov 13, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm now checking _http_vsn and only send the ALPN extension when the version is 11 (HTTP/1.1).

@tiran
bpo-40968: Send http/1.1 ALPN extension
977ec2a 
Signed-off-by: Christian Heimes <christian@python.org>
@tiran tiran added type-feature A feature request or enhancement and removed needs backport to 3.7 type-bug An unexpected behavior, bug, or error labels Nov 13, 2020
@tiran tiran marked this pull request as ready for review November 13, 2020 09:05
sethmlarson
sethmlarson approved these changes Nov 13, 2020
View reviewed changes
Copy link
Contributor

@sethmlarson sethmlarson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiran tiran merged commit f97406b into python:master Nov 13, 2020
@bedevere-bot
Copy link

bedevere-bot commented Nov 13, 2020

@tiran: Please replace # with GH- in the commit message next time. Thanks!

@tiran tiran deleted the bpo-40968-alpn branch November 13, 2020 15:37
@handlerbot handlerbot mentioned this pull request Mar 5, 2021
Merged
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@tiran @adorilson
bpo-40968: Send http/1.1 ALPN extension (python#20959)
a393bca 
Signed-off-by: Christian Heimes <christian@python.org>
@pmenzel pmenzel mannequin mentioned this pull request May 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sethmlarson sethmlarson sethmlarson approved these changes

Assignees

No one assigned

Labels

type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tiran @bedevere-bot @sethmlarson @the-knights-who-say-ni