bpo-1635741: Port mmap module to multiphase initialization#19459
Merged
corona10 merged 4 commits intopython:masterfrom Jun 5, 2020
Merged
bpo-1635741: Port mmap module to multiphase initialization#19459corona10 merged 4 commits intopython:masterfrom
corona10 merged 4 commits intopython:masterfrom
Conversation
corona10
changed the title
vstinner
approved these changes
Jun 5, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. mmap code would deserve better error handling, but that can be addressed in a separated PR.
Apart static types, I don't anything which would be shared by multiple module instances/interpreters.
corona10
force-pushed
the
bpo-1635741-mmap
branch
from
623259b to
d3b55d7
Compare
vstinner
reviewed
Jun 5, 2020
vstinner
reviewed
Jun 5, 2020
vstinner
approved these changes
Jun 5, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM apart the PyExc_OSError bug.
Member
Author
|
@vstinner @shihai1991 Thanks for the reviews! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741