bpo-29569: threading.Timer class: Continue periodical execution till action return True#191
Closed
slytomcat wants to merge 1 commit intopython:masterfrom
slytomcat:Periodical.Timer
Closed
bpo-29569: threading.Timer class: Continue periodical execution till action return True#191slytomcat wants to merge 1 commit intopython:masterfrom slytomcat:Periodical.Timer
slytomcat wants to merge 1 commit intopython:masterfrom
slytomcat:Periodical.Timer
Conversation
…rn True + tests + doc
Author
|
It is reopened (due to need to reorganize my clonned repo) CR #121 |
Author
|
Closed after discussion on the issue. |
akruis
added a commit
to akruis/cpython
that referenced
this pull request
Dec 27, 2018
Use/implement tp_dealloc/tp_new/tp_free according to the latest C-API documentation.
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think that functionality of threading.Timer class can be easily extended to generate the sequence of runs with specified period. The idea comes from the GLib.timeout_add function.
http://bugs.python.org/issue29569
As most current CB functions that are used in Timer returns nothing (None) they will run only once as earlier. Only functions that returns True will continue their periodical execution.
There are two ways to stop such continues execution:
Changed method run should look like: