bpo-1635741: Port statistics module to multiphase initialization#19015
Merged
vstinner merged 2 commits intopython:masterfrom Mar 16, 2020
Merged
bpo-1635741: Port statistics module to multiphase initialization#19015vstinner merged 2 commits intopython:masterfrom
vstinner merged 2 commits intopython:masterfrom
Conversation
Member
Author
|
@shihai1991 Can you please take a look? |
shihai1991
approved these changes
Mar 15, 2020
Member
shihai1991
left a comment
shihai1991
left a comment
There was a problem hiding this comment.
I have checked this source file(there have no _Py_IDENTIFIER or global vars), so this PR LGTM, thanks.
Member
vstinner
reviewed
Mar 16, 2020
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM, but please fix the typo in the commit message and in the NEWS entry: it's the private _statistics module, not statistics :-)
Misc/NEWS.d/next/Core and Builtins/2020-03-15-20-51-15.bpo-1635741.iH0JND.rst
Outdated
Show resolved
Hide resolved
…5741.iH0JND.rst Co-Authored-By: Victor Stinner <vstinner@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741