bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly#17892
Merged
pablogsal merged 1 commit intopython:masterfrom Mar 9, 2020
Merged
bpo-38870: Simplify tuple like interleaves, roundtrip extslice properly#17892pablogsal merged 1 commit intopython:masterfrom
pablogsal merged 1 commit intopython:masterfrom
Conversation
pablogsal
reviewed
Jan 7, 2020
pablogsal
reviewed
Jan 7, 2020
Member
Author
|
Thanks for the suggestions @pablogsal! |
pablogsal
reviewed
Jan 7, 2020
Member
|
The build is failing because you have trailing whitespace (you can run |
Member
Author
|
Already fixed on the master with GH-18824 |
Member
Author
|
Actually we can still apply this simplification |
d78d34f to
6715561
Compare
6715561 to
967c4cc
Compare
pablogsal
reviewed
Mar 9, 2020
967c4cc to
a7a228d
Compare
pablogsal
approved these changes
Mar 9, 2020
colesbury
referenced
this pull request
in colesbury/nogil
Oct 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue38870