Fix definition of multiple ']' in header#17086
Fix definition of multiple ']' in header#17086mark99i wants to merge 2 commits intopython:masterfrom mark99i:patch-1
Conversation
in old version in example header is "[i love [python] lang]" parse as "i love [python", only up to the first character ']'. once fixed, multiple ']' can be used and this will not cause the header to be clipped. now saving works correctly, but reading does not
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). Recognized GitHub usernameWe couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames: This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
brandtbucher
left a comment
There was a problem hiding this comment.
Sorry @mark99i, but I think this PR should be closed in favor of #17129, since it includes tests and doesn't break handling on the empty case.
Please make sure to include the "bpo-#####: " prefix in the PR title next time so that it properly links to the issue and others can see that you've begun work.
|
Thanks for your time though... definitely looking forward to seeing more contributions from you in the future! |
Fix definition of multiple ']' in header in configparser
in old version in example header is "[i love [python] lang]"
parse as "i love [python", only up to the first character ']'.
once fixed, multiple ']' can be used and this will not cause the header to be clipped.
now saving works correctly, but reading does not