gh-82565: Fix a possible assertion failure in _pickle

[ZackerySpytz]

In _Unpickler_SetInputStream(), _PyObject_LookupAttrId() is called
three times in a row without any error handling. If an exception
occurs during the first or second call, _PyObject_LookupAttrId()
will be called with a live exception.

https://bugs.python.org/issue38384

• Issue: An assertion failure in test_pickle #82565

[serhiy-storchaka]

Please add a test.

[bedevere-bot]

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

[serhiy-storchaka]

Minimal reproducer (but you can add readline and readinto):

class F:
    @property
    def read(self):
        1/0

import pickle
pickle.load(F())

[taleinat]

@ZackerySpytz Ping?

[taleinat]

Hi @ZackerySpytz! This is looking good!

Make sure to also add a NEWS entry (you can use blurb-it).

[iritkatriel]

Please add a test.

@ZackerySpytz has added a test. Shall we merge this?

[furkanonder]

LGTM. @serhiy-storchaka

[serhiy-storchaka]

LGTM.

Please add few more test cases:

• no read, no readline
• read = bad_property, no readline
• readline = bad_property, no read

[serhiy-storchaka]

Sorry, I forget to merge this PR at its time, so the original issue was fixed in #105667.

But the tests may still be useful.

[miss-islington-app]

Thanks @ZackerySpytz for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[bedevere-app]

GH-112591 is a backport of this pull request to the 3.12 branch.

[bedevere-app]

GH-112592 is a backport of this pull request to the 3.11 branch.