Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion Lib/profiling/tracing/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,10 @@ def main():
# in the module's namespace.
globs = module.__dict__
globs.update({
'__spec__': spec,
# See gh-140729, set None to __spec__ according
# to the documentation,
# https://docs.python.org/3/reference/import.html#module-specs
'__spec__': None,
'__file__': spec.origin,
'__name__': spec.name,
'__package__': None,
Expand Down
47 changes: 47 additions & 0 deletions Lib/test/test_profiling/test_sampling_profiler.py
Original file line number Diff line number Diff line change
Expand Up @@ -3356,5 +3356,52 @@ def worker(x):

self.assertIn("Results: [2, 4, 6]", stdout)
self.assertNotIn("Can't pickle", stderr)

@requires_subprocess()
@skip_if_not_supported
class TestProcessRunSupport(unittest.TestCase):
"""
Test that ProcessPoolExecutor works correctly with profiling.sampling.
"""

def test_process_run_pickle(self):
# gh-140729: test use ProcessPoolExecutor.map() can sampling
val = 10000
test_script = f'''
import multiprocessing

def worker(x):
print(__name__)
print('x =', x)
return x * 2

if __name__ == "__main__":
multiprocessing.set_start_method("spawn")
p = multiprocessing.Process(target=worker, args=({val},))
p.start()
p.join()
'''
with os_helper.temp_dir() as temp_dir:
script = script_helper.make_script(
temp_dir, 'test_process_run_pickle', test_script
)
with SuppressCrashReport():
with script_helper.spawn_python(
"-m", "cProfile",
script,
stdout=subprocess.PIPE,
stderr=subprocess.PIPE,
text=True
) as proc:
try:
stdout, stderr = proc.communicate(timeout=SHORT_TIMEOUT)
except subprocess.TimeoutExpired:
proc.kill()
stdout, stderr = proc.communicate()

self.assertIn(f"x = {val}", stdout)
self.assertIn("__mp_main__", stdout)
self.assertNotIn("Can't pickle", stderr)

if __name__ == "__main__":
unittest.main()
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
Fix pickling error in the cProfile module when using ``multiprocessing.Process``
or ``concurrent.futures.ProcessPoolExecutor`` script, which can not be
properly pickled and executed.