gh-141563: make PyDateTime_IMPORT thread-safe
#144210
Draft
+15
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumaraditya303
force-pushed
the
datetime
branch
2 times, most recently
from
ea5a3ea to
a6f6595
Compare
kumaraditya303
force-pushed
the
datetime
branch
2 times, most recently
from
3b08a06 to
96a62cb
Compare
kumaraditya303
force-pushed
the
datetime
branch
from
96a62cb to
36a06c8
Compare
vstinner
reviewed
Jan 27, 2026
| #define PyDateTime_IMPORT \ | ||
| PyDateTimeAPI = (PyDateTime_CAPI *)PyCapsule_Import(PyDateTime_CAPSULE_NAME, 0) | ||
| static inline PyDateTime_CAPI * | ||
| PyDateTime_IMPORT(void) { |
Member
There was a problem hiding this comment.
The intended usage is just PyDateTime_IMPORT;. We need more black magic here:
- Rename
PyDateTime_IMPORT()to_PyDateTime_IMPORT() - Add
#define PyDateTime_IMPORT _PyDateTime_IMPORT()macro
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datetimeC API is not thread-safe #141563