gh-136728: Refactor build.yml CI config and multissltests.py #143940
+200
−191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webknjaz
reviewed
Jan 16, 2026
webknjaz
reviewed
Jan 16, 2026
webknjaz
reviewed
Jan 16, 2026
picnixz
reviewed
Jan 17, 2026
|
|
||
| @property | ||
| @abstractmethod | ||
| def library(self=None): |
Member
There was a problem hiding this comment.
So as I said previously, we should just have annotated properties. It will complain at runtime if we are missing one.
Member
Author
There was a problem hiding this comment.
Please could you make GH suggestions here, or a PR to my branch?
Member
There was a problem hiding this comment.
I am sorry I am on mobile only (I am travelling) so I cannot do it easily :(
Co-authored-by: Bénédikt Tran <[email protected]>
hugovk
commented
Jan 20, 2026
Member
|
There was a new round of OpenSSL updates on 2026-01-27. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #136729.
Original description:
Notes
Please see #136728. Changes to
build.ymlare directly adapted from @hugovk's proof-of-concept here.Testing