gh-106318: Improve str.rstrip() method doc #143893
Merged
+19
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…method doc str.removesuffix() docs have their own examples.
vstinner
reviewed
Jan 19, 2026
Co-authored-by: Victor Stinner <[email protected]>
nedbat
reviewed
Feb 10, 2026
Doc/library/stdtypes.rst
Outdated
|
|
||
| See :meth:`str.removesuffix` for a method that will remove a single suffix | ||
| string rather than all of a set of characters. For example:: | ||
| See also :meth:`strip` and :meth:`removesuffix`. |
Member
There was a problem hiding this comment.
We should keep the original for these lines.
- it is eye-catching and surprising
- It shows the two methods side-by-side.
- it honors our forebearers.
Member
There was a problem hiding this comment.
I agree. I like these 'Monty Python' examples, I would also prefer to keep them.
Contributor
Author
There was a problem hiding this comment.
Done. With other improvements.
…split() method doc" This reverts commit 9fa3ecc. As asked by @nedbat on pythongh-143893
nedbat
approved these changes
Feb 11, 2026
Member
|
Merged, thanks. |
vstinner
added
needs backport to 3.13
|
Thanks @adorilson for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
|
Thanks @adorilson for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2026
(cherry picked from commit 936d60d) Co-authored-by: Adorilson Bezerra <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 11, 2026
(cherry picked from commit 936d60d) Co-authored-by: Adorilson Bezerra <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
|
GH-144698 is a backport of this pull request to the 3.13 branch. |
|
GH-144699 is a backport of this pull request to the 3.14 branch. |
Member
|
Merged, thanks. |
vstinner
added a commit
that referenced
this pull request
Feb 11, 2026
gh-106318: Improve str.rstrip() method doc (GH-143893) (cherry picked from commit 936d60d) Co-authored-by: Adorilson Bezerra <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
vstinner
added a commit
that referenced
this pull request
Feb 11, 2026
gh-106318: Improve str.rstrip() method doc (GH-143893) (cherry picked from commit 936d60d) Co-authored-by: Adorilson Bezerra <[email protected]> Co-authored-by: Victor Stinner <[email protected]> Co-authored-by: Stan Ulbrych <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP to #106318
#106318: Improve str.rstrip() method doc
📚 Documentation preview 📚: https://cpython-previews--143893.org.readthedocs.build/