gh-116738: Make zlib module thread-safe#142432
Merged
colesbury merged 3 commits intopython:mainfrom Dec 12, 2025
Merged
Conversation
colesbury
reviewed
Dec 9, 2025
emmatyping
reviewed
Dec 11, 2025
emmatyping
approved these changes
Dec 12, 2025
colesbury
approved these changes
Dec 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the
zlibmodule thread-safe free-threading build. Even though operations are protected by locks, attributes exposed viaPyMemberDef (eof, needs_input, unused_data, unconsumed_tail)should still be stored atomically within locked sections, since they can be read without acquiring the lock.PyThread_type_lockwithPyMutex(similar to gh-116738: Use PyMutex for bz2 module #140555 and gh-116738: Use PyMutex for lzma module #140711)ENTER_ZLIB/LEAVE_ZLIBmacros in favor of directPyMutex_Lock/Unlock(similar to gh-116738: Use PyMutex for bz2 module #140555 and gh-116738: Use PyMutex for lzma module #140711)FT_ATOMIC_STORE_CHAR_RELAXEDforeofandneeds_inputflag updates inside locked sections (attributes exposed viaPyMemberDef)unused_data/unconsumed_tailfromPyMemberDeftoPyGetSetDefcc: @mpage @colesbury