gh-140702: Add test skip for Unix Datagram tests on iOS when on Github Actions#140740
Merged
freakboy3742 merged 6 commits intopython:mainfrom Oct 29, 2025
Merged
Conversation
hugovk
approved these changes
Oct 29, 2025
hugovk
reviewed
Oct 29, 2025
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
Thanks @freakboy3742 for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Oct 29, 2025
… Github Actions (pythonGH-140740) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
GH-140742 is a backport of this pull request to the 3.14 branch. |
freakboy3742
added a commit
that referenced
this pull request
Oct 29, 2025
…n Github Actions (GH-140740) (#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
|
StanFromIreland
pushed a commit
to StanFromIreland/cpython
that referenced
this pull request
Dec 6, 2025
… Github Actions (python#140740) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…when on Github Actions (pythonGH-140740) (python#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…when on Github Actions (pythonGH-140740) (python#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…when on Github Actions (pythonGH-140740) (python#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
freakboy3742
added a commit
to freakboy3742/cpython
that referenced
this pull request
Feb 3, 2026
…when on Github Actions (pythonGH-140740) (python#140742) Exposes the GITHUB_ACTIONS environment variable to iOS simulator test runs, and uses this variable to skip a Unix Datagram socketserver test that is unreliable in the iOS GitHub Actions environment. (cherry picked from commit 9f8d005) Co-authored-by: Russell Keith-Magee <russell@keith-magee.com> Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On GitHub Actions, it appears that the UnixDatagramServer tests are unstable on the iOS simulator.
This test has been running successfully on the buildbot for months; I think I've seen one failure in the last 6 months that might be the same cause.
I can't reproduce the failure locally. But it appears that on GitHub Actions, the test fails regularly. I have spent the day trying to work out why, without a whole lot of success - mostly because it can only be replicated on GitHub Actions. And given the problems that GitHub have been having with the macOS-15 runners for the last couple of months, it doesn't seem out of the question that there may be systemic problems with the platform that will be resolved with time.
This PR skips the 2 affected tests, but only on iOS simulator, when running on GitHub Actions. It exposes the GITHUB_ACTIONS variable to the running iOS app environment to make this possible.
I don't like this fix; but at this point, it seems the pragmatic option. The underlying test will still run on buildbots, and on individual tests.