improve isolation of test_pending_call_creates_thread_subinterpreter#139473
improve isolation of test_pending_call_creates_thread_subinterpreter#139473kumaraditya303 wants to merge 3 commits intopython:mainfrom
Conversation
|
🤖 New build scheduled with the buildbot fleet by @kumaraditya303 for commit 0cb09f9 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F139473%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
I'm not sure I understand the rationale here. We already have a test for doing this in a subprocess: |
Yes, but that runs in main interpreter but this runs in a sub-interpreter. |
|
But why do it in a subprocess? We create and destroy subinterpreters in the main process in other tests, don't we? |
|
I no longer think this is correct so closed it. |
For better isolation from the current runtime, run the test in a separate subprocess similarly to
test_pending_call_creates_thread.