Skip to content

gh-53203: Fix strptime() for %c, %x and %X formats on some locales#135971

Merged
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:strptime-calc-alt-digits
Jun 27, 2025
Merged

gh-53203: Fix strptime() for %c, %x and %X formats on some locales#135971
serhiy-storchaka merged 1 commit intopython:mainfrom
serhiy-storchaka:strptime-calc-alt-digits

Conversation

@serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jun 26, 2025 •
edited
Loading

  • Add detection of decimal non-ASCII alt digits.
  • Add support of non-decimal alt digits on locale lzh_TW.
  • Accept only numbers in correct range if alt digits are known.
  • Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
  • Fix support of single-digit hour on locales ar_SA and bg_BG.
  • Add support for %T, %R, %r, %C, %OC.
  • Prepare code to use nl_langinfo().

@serhiy-storchaka
pythongh-53203: Fix strptime() for %c, %x and %X formats on some locales
196f060 
* %c and %x formats on locales byn_ER, wal_ET and lzh_TW
* %X format on locales ar_SA, bg_BG and lzh_TW

Prepare code to use nl_langinfo().
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 26, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 26, 2025
Closed
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jun 26, 2025

@kulikjak, could you please test this PR on Solaris?

@kulikjak
Copy link
Contributor

kulikjak commented Jun 26, 2025

Sure, I tested the change and the test passes. We do not have those three letter locales, but both 'ar_SA' and 'bg_BG' are green.

Thanks for the ping!

@serhiy-storchaka serhiy-storchaka merged commit 07183eb into python:main Jun 27, 2025
46 checks passed
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 27, 2025

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@serhiy-storchaka serhiy-storchaka deleted the strptime-calc-alt-digits branch June 27, 2025 07:51
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@serhiy-storchaka @miss-islington
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
0c686d3 
…les (pythonGH-135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
(cherry picked from commit 07183eb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 27, 2025
@serhiy-storchaka @miss-islington
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
7d6d96d 
…les (pythonGH-135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
(cherry picked from commit 07183eb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jun 27, 2025

GH-136019 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jun 27, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jun 27, 2025

GH-136020 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 27, 2025
@serhiy-storchaka
Copy link
Member Author

serhiy-storchaka commented Jun 27, 2025

Thank you for testing.

serhiy-storchaka added a commit that referenced this pull request Jun 27, 2025
@miss-islington @serhiy-storchaka
[3.13] gh-53203: Fix strptime() for %c, %x and %X formats on some loc…
ea25f4a 
…ales (GH-135971) (GH-136020)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().

(cherry picked from commit 07183eb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Jun 27, 2025
@miss-islington @serhiy-storchaka
[3.14] gh-53203: Fix strptime() for %c, %x and %X formats on some loc…
a168c77 
…ales (GH-135971) (GH-136019)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().

(cherry picked from commit 07183eb)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
AndPuQing pushed a commit to AndPuQing/cpython that referenced this pull request Jul 11, 2025
@serhiy-storchaka @AndPuQing
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
91edb74 
…les (python#135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025
@serhiy-storchaka @Pranjal095
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
3a93f40 
…les (python#135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025
@serhiy-storchaka @taegyunkim
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
ae83ab6 
…les (python#135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
Agent-Hellboy pushed a commit to Agent-Hellboy/cpython that referenced this pull request Aug 19, 2025
@serhiy-storchaka @Agent-Hellboy
pythongh-53203: Fix strptime() for %c, %x and %X formats on some loca…
95a4e72 
…les (python#135971)

* Add detection of decimal non-ASCII alt digits.
* Add support of non-decimal alt digits on locale lzh_TW.
* Accept only numbers in correct range if alt digits are known.
* Fix bug in detecting the position of the week day name on locales byn_ER and wal_ET.
* Fix support of single-digit hour on locales ar_SA and bg_BG.
* Add support for %T, %R, %r, %C, %OC.
* Prepare code to use nl_langinfo().
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pganssle pganssle Awaiting requested review from pganssle pganssle is a code owner

@abalkin abalkin Awaiting requested review from abalkin abalkin is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@serhiy-storchaka @kulikjak