gh-134821: Automatically enable deferred reference counting on shared objects#134880
Closed
ZeroIntensity wants to merge 2 commits intopython:mainfrom
Closed
gh-134821: Automatically enable deferred reference counting on shared objects#134880ZeroIntensity wants to merge 2 commits intopython:mainfrom
ZeroIntensity wants to merge 2 commits intopython:mainfrom
Conversation
corona10
reviewed
Jun 1, 2025
Member
corona10
left a comment
There was a problem hiding this comment.
Could you run the pyperformance benchmark first?
Member
Author
|
Sorry for the delay! The pyperformance benchmarks are showing quite a hit in performance:
Considering this approach is pretty non-intrusive, I suspect automatic DRC just isn't feasible right now, because there will always be false positive "shared" objects no matter how we implement it, and those false positives will experience an apparent 30% hit in performance. I think that individual patches, like #134762, will turn out to work pretty well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a very rough POC. I think it's important that we don't cause performance regressions here, so I've implemented this alongside the garbage collector.
Does this approach make sense to everyone?