Skip to content

gh-114177: avoid calling connection lost callbacks when loop is already closed in asyncio subprocess #134508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kumaraditya303 merged 3 commits into from
May 23, 2025
Merged

gh-114177: avoid calling connection lost callbacks when loop is already closed in asyncio subprocess #134508

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7700a54
avoid calling connection lost callbacks when loop is closed
kumaraditya303 May 22, 2025
6f52c06
📜🤖 Added by blurb_it.
blurb-it[bot] May 22, 2025
60cef45
Update Lib/asyncio/base_subprocess.py
kumaraditya303 May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Lib/asyncio/base_subprocess.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,12 @@ def close(self):
for proto in self._pipes.values():
if proto is None:
continue
proto.pipe.close()
# See https://github.com/python/cpython/issues/114177
Comment thread
kumaraditya303 marked this conversation as resolved.
Outdated
# skip closing the pipe if loop is already closed
# this can happen e.g. when loop is closed immediately after
# process is killed
if self._loop and not self._loop.is_closed():
proto.pipe.close()

if (self._proc is not None and
# has the child process finished?
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2025-05-22-13-10-32.gh-issue-114177.3TYUJ3.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Fix :mod:`asyncio` to not close subprocess pipes which would otherwise error out when the event loop is already closed.
Loading