gh-117657: Fix data race in compare_unicode_unicode_threadsafe#131746
Merged
colesbury merged 1 commit intopython:mainfrom Mar 26, 2025
Merged
gh-117657: Fix data race in compare_unicode_unicode_threadsafe#131746colesbury merged 1 commit intopython:mainfrom
compare_unicode_unicode_threadsafe#131746colesbury merged 1 commit intopython:mainfrom
Conversation
We can't safely check the type of the found key until we safely incref it or if we know that it's immortal.
Contributor
Author
|
Should fix the race seen https://github.com/python/cpython/actions/runs/14068787835/job/39397782588: |
mpage
approved these changes
Mar 25, 2025
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 1, 2025
pythongh-131746) We can't safely check the type of the found key until we incref it or if we know that it's immortal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We can't safely check the type of the found key until we incref it or if we know that it's immortal.