Skip to content

gh-117657: Fix TSAN data race in _PyEval_SetTrace assertion#131561

Merged
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-117657-set-trace-assert
Mar 21, 2025
Merged

gh-117657: Fix TSAN data race in _PyEval_SetTrace assertion#131561
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-117657-set-trace-assert

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 21, 2025 •
edited by bedevere-app bot
Loading

The sys_tracing_threads variable should be read inside LOCK_SETUP().

@colesbury
pythongh-117657: Fix TSAN data race in _PyEval_SetTrace assertion
d035a90 
The `sys_tracing_threads` variable should be read inside LOCK_SETUP().
@bedevere-app bedevere-app bot mentioned this pull request Mar 21, 2025
Closed
@colesbury colesbury merged commit 0de5e0c into python:main Mar 21, 2025
51 checks passed
@colesbury colesbury deleted the gh-117657-set-trace-assert branch March 21, 2025 18:22
@colesbury colesbury added the needs backport to 3.13 bugs and security fixes label Mar 21, 2025
@miss-islington-app
Copy link

miss-islington-app bot commented Mar 21, 2025

Thanks @colesbury for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Mar 21, 2025
@colesbury @miss-islington
pythongh-117657: Fix TSAN data race in _PyEval_SetTrace assertion (py…
b38f60d 
…thongh-131561)

The `sys_tracing_threads` variable should be read inside `LOCK_SETUP()`.
(cherry picked from commit 0de5e0c)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Mar 21, 2025

GH-131564 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Mar 21, 2025
colesbury added a commit that referenced this pull request Mar 21, 2025
@miss-islington @colesbury
[3.13] gh-117657: Fix TSAN data race in _PyEval_SetTrace assertion (g…
94fbe97 
…h-131561) (#131564)

The `sys_tracing_threads` variable should be read inside `LOCK_SETUP()`.
(cherry picked from commit 0de5e0c)

Co-authored-by: Sam Gross <colesbury@gmail.com>
@nascheme nascheme mentioned this pull request Apr 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@DinoV DinoV Awaiting requested review from DinoV

Assignees

No one assigned

Labels

skip news topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@colesbury @kumaraditya303