GH-131238: Core header refactor#131250
Merged
markshannon merged 12 commits intopython:mainfrom Mar 17, 2025
Merged
Conversation
markshannon
added
the
🔨 test-with-buildbots
|
🤖 New build scheduled with the buildbot fleet by @markshannon for commit 4231362 🤖 Results will be shown at: https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F131250%2Fmerge If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
bedevere-bot
removed
the
🔨 test-with-buildbots
markshannon
requested review from
1st1,
Fidget-Spinner,
abalkin,
brettcannon,
ericsnowcurrently,
erlend-aasland,
gpshead,
lysnikolaou,
ncoghlan,
pablogsal,
pganssle,
tiran and
warsaw
as code owners
vstinner
reviewed
Mar 14, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
Please add also the 3 new internal headers to PCbuild/pythoncore.vcxproj and PCbuild/pythoncore.vcxproj.filters.
vstinner
reviewed
Mar 14, 2025
vstinner
approved these changes
Mar 14, 2025
Member
vstinner
left a comment
vstinner
left a comment
There was a problem hiding this comment.
LGTM. I like the overall design. I just left a few minor comments which can be addressed later if needed (I can handle them if you want).
plashchynski
pushed a commit
to plashchynski/cpython
that referenced
this pull request
Mar 17, 2025
* Moves most structs in pycore_ header files into pycore_structs.h and pycore_runtime_structs.h * Removes many cross-header dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves most of the struct definitions in the various "core" header files to new header files.
This breaks the dependencies between header files, as headers do not need to include each other, but can include one or two of the struct definition headers.