Skip to content

gh-130396: Fix thread sanitizer crashes on stack overflow tests#130966

Merged
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-130396-tsan-crash
Mar 11, 2025
Merged

gh-130396: Fix thread sanitizer crashes on stack overflow tests#130966
colesbury merged 1 commit intopython:mainfrom
colesbury:gh-130396-tsan-crash

Conversation

@colesbury
Copy link
Contributor

@colesbury colesbury commented Mar 7, 2025

Thread sanitizer will often crash if a test uses more than half the stack.

Thread sanitizer will often crash if a test uses more than half the
stack.
@colesbury
Copy link
Contributor Author

For example the following previously crashed with SIGBUS on exit, but works with the PR:

./python -m test -u cpu test_descr -m test_wrapper_segfault -v

I tested with reduce stack sizes as well (ulimit -s 4096 and ulimit -s 2048).

Copy link
Contributor

@mpage mpage left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@colesbury colesbury merged commit 4162bc1 into python:main Mar 11, 2025
54 checks passed
@colesbury colesbury deleted the gh-130396-tsan-crash branch March 11, 2025 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants