Conversation
PyEval_ReInitThread can run arbitrary Python code, which really ought to have the TLS initialized.
berkerpeksag
approved these changes
Feb 21, 2017
Member
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
I'm not really qualified to review this, but... since you're the RM of 2.7 and this is a backport from Python 3 here's my +1 :)
akruis
referenced
this pull request
in stackless-dev/stackless
Sep 5, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
Pickling of an exhausted generator no longer causes a segmentation fault. https://bitbucket.org/stackless-dev/stackless/issues/130 (grafted from b86bda31f4e3372bbde61179cc890af24d83ae71)
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Sep 9, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Nov 7, 2017
akruis
pushed a commit
to akruis/cpython
that referenced
this pull request
Mar 25, 2018
pablogsal
pushed a commit
to pablogsal/cpython
that referenced
this pull request
Aug 13, 2022
This was referenced Feb 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyEval_ReInitThread can run arbitrary Python code, which really ought to have
the TLS properly initialized. This essentially backports the Python 3 ordering.