gh-127073: Clear completion list when KeyboardInterrupt occurs in REPL#128467
gh-127073: Clear completion list when KeyboardInterrupt occurs in REPL#128467Natural-selection1 wants to merge 7 commits intopython:mainfrom
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Previously, the completion list would persist after a KeyboardInterrupt was triggered. This change ensures the completion state is properly reset.
4e67b83 to
cbe2f11
Compare
| @@ -0,0 +1,4 @@ | |||
| Previously in the REPL, when a completion list was displayed and KeyboardInterrupt | |||
There was a problem hiding this comment.
Love the effort, but this is too long. Can we shorten this to a single sentence? (We don't need technical details, just what was fixed.)
|
@Natural-selection1 Please, do not merge main into your branch if there is no conflict to solve or if nothing has changed since the last commit. In addition, please consider addressing comments by ZeroIntensity first. |
Sorry for any inconvenience caused. As a newcomer contributing to a large project like CPython, I sincerely regret the issues. Regarding the previously mentioned problems, I am actively working on resolving them. As for the test cases that need to be written, I am making efforts, though it may take some time to complete. I will treat this experience as a valuable learning opportunity. |
|
No worries. For now, I'll mark your PR as a draft. Once you've added the tests and rewritten the NEWS entry, just convert it back to a "ready-for-review" PR. |
|
The following commit authors need to sign the Contributor License Agreement: |
Resolve #127073
New behavior:
The completion list is properly cleared on KeyboardInterrupt just consistent with the behavior of other errors
int.<TAB><TAB><Ctrl+C>