gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning#128007
gh-121604: Make sure all deprecated items in importlib raise DeprecationWarning#128007brettcannon merged 15 commits intopython:mainfrom
Conversation
Co-authored-by: rashansmith <smith.rashan@gmail.com>
Co-authored-by: rashansmith <smith.rashan@gmail.com>
…CODE_SUFFIXES. Co-authored-by: rashansmith <smith.rashan@gmail.com>
Co-authored-by: rashansmith <smith.rashan@gmail.com>
tomasr8
requested review from
brettcannon,
ericsnowcurrently,
ncoghlan and
warsaw
as code owners
StanFromIreland
left a comment
StanFromIreland
left a comment
There was a problem hiding this comment.
Two little things I noticed. I did not have time to go through the rest but it looks good in general.
Co-authored-by: Stan Ulbrych <89152624+StanFromIreland@users.noreply.github.com>
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Sorry about the review delay! |
Co-authored-by: Brett Cannon <brett@python.org>
No worries, and thanks for the review! I think I addressed your comments if you feel like having another look :) I have made the requested changes; please review again |
|
Thanks for making the requested changes! @brettcannon: please review the changes made to this pull request. |
Misc/NEWS.d/next/Library/2024-12-16-22-20-38.gh-issue-121604.m3Xn4G.rst
Outdated
Show resolved
Hide resolved
|
Thanks, @tomasr8 for bearing with me and my delayed reviews! 😅 |
|
No worries :) Thanks for the review! |
4 participants
Largely based on work done by @rashansmith, this adds deprecation warnings for the following importlib classes, methods and attributes (using the docs as the source of truth):
The deprecation messages are based on the docs. Warnings for
DEBUG_BYTECODE_SUFFIXESandOPTIMIZED_BYTECODE_SUFFIXESare implemented using a module__getattr__.Feedback welcome!
DeprecationWarning#121604