gh-126138: Fix UAF in asyncio.Task when task calls back to user defined cancel function#126305
Merged
kumaraditya303 merged 4 commits intopython:mainfrom Nov 2, 2024
Merged
Conversation
Nico-Posada
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
Contributor
Author
|
Oh it seems I pulled in my change from #126230 too, don't think it'll cause any issues though. Can remove if needed. |
picnixz
reviewed
Nov 1, 2024
Member
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
Thanks for the patch Nico! I gave you some suggestions for the comments but feel free to change where the line ends (hard to see where the 80-chars limit lie on GH Web UI).
Misc/NEWS.d/next/Library/2024-11-01-14-31-41.gh-issue-126138.yTniOG.rst
Outdated
Show resolved
Hide resolved
picnixz
added
needs backport to 3.12
kumaraditya303
approved these changes
Nov 2, 2024
|
Thanks @Nico-Posada for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 2, 2024
…attribute__` (pythonGH-126305) (cherry picked from commit f032f6b) Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 2, 2024
…attribute__` (pythonGH-126305) (cherry picked from commit f032f6b) Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
|
GH-126324 is a backport of this pull request to the 3.13 branch. |
|
GH-126325 is a backport of this pull request to the 3.12 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 2, 2024
…tattribute__` (GH-126305) (#126325) gh-126138: Fix use-after-free in `_asyncio.Task` by evil `__getattribute__` (GH-126305) (cherry picked from commit f032f6b) Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
kumaraditya303
pushed a commit
that referenced
this pull request
Nov 2, 2024
…tattribute__` (GH-126305) (#126324) gh-126138: Fix use-after-free in `_asyncio.Task` by evil `__getattribute__` (GH-126305) (cherry picked from commit f032f6b) Co-authored-by: Nico-Posada <102486290+Nico-Posada@users.noreply.github.com> Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
picnixz
pushed a commit
to picnixz/cpython
that referenced
this pull request
Dec 8, 2024
…attribute__` (python#126305) Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
ebonnal
pushed a commit
to ebonnal/cpython
that referenced
this pull request
Jan 12, 2025
…attribute__` (python#126305) Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No test cases because of how similar this is to #126120, but can add if needed. Blurb definitely needs some revision too because I'm bad at explaining things sometimes.
__getattribute__when calling a class'scancelfunction intask_step_handle_result_implin_asynciomodule.c#126138