gh-125028: Prohibit placeholders in partial keywords by dg-pb · Pull Request #126062 · python/cpython

dg-pb · 2024-10-28T06:53:16Z

Issue: Prohibit placeholders in partial keywords #125028

…hibit-kw-placeholders

Lib/functools.py

Modules/_functoolsmodule.c

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

Lib/test/test_functools.py

Modules/_functoolsmodule.c

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland

Please amend Doc/library/functools.rst and Doc/whatsnew/3.14.rst as needed.

bedevere-app · 2025-01-05T20:40:11Z

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

dg-pb · 2025-01-05T21:40:31Z

I have made the requested changes; please review again

bedevere-app · 2025-01-05T21:40:36Z

Thanks for making the requested changes!

@erlend-aasland: please review the changes made to this pull request.

erlend-aasland · 2025-01-05T21:45:40Z

Thanks, looks good to me. I'd like Serhiy's eyes on it also.

Lib/test/test_functools.py

Lib/functools.py

Modules/_functoolsmodule.c

serhiy-storchaka

LGTM.

Lib/test/test_functools.py

dg-pb · 2025-05-08T00:50:26Z

@rhettinger, @serhiy-storchaka
This is API adjustment for new feature, thus I think it would be good to merge this before 3.14 release. Given it is a fairly small one, maybe it would be good to get it out of the way sooner than later?

Also, what are your thoughts on:

gh-119109: improve functools.partial vectorcall with keywords #124584 - in addition to intended improvements this one solves current free-threading issue (the last one in that series) - Race between partial_vectorcall_fallback and _PyVectorcall_FunctionInline under free-threading #128050
gh-124652: partialmethod simplifications #124788 - this one would simplify some complexity in inspect and make partialmethod a bit more performant

Should either of the above be aimed to be merged before 3.14 or is it not of importance?

serhiy-storchaka

LGTM. 👍

It should go in 3.14, no question. It is much easier to prohibit this in 3.14, that in any following version, when we would need to pass through a deprecation process. On other hand, we can allow Placeholder as a keyword argument at any time if it is needed.

miss-islington-app · 2025-05-08T07:53:57Z

Thanks @dg-pb for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

…126062) (cherry picked from commit afed5f8) Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>

bedevere-app · 2025-05-08T07:54:09Z

GH-133645 is a backport of this pull request to the 3.14 branch.

… (GH-133645) (cherry picked from commit afed5f8) Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>

…126062)

dg-pb and others added 5 commits October 9, 2024 18:07

impl

8b08ed5

📜🤖 Added by blurb_it.

bea722a

Merge remote-tracking branch 'upstream/main' into pythongh-125028-pro…

f346390

…hibit-kw-placeholders

Merge remote-tracking branch 'upstream/main' into pythongh-125028-pro…

c7ee84b

…hibit-kw-placeholders

remove news

e741a5c

dg-pb requested a review from rhettinger as a code owner October 28, 2024 06:53

bedevere-app bot added the awaiting review label Oct 28, 2024

bedevere-app bot mentioned this pull request Oct 28, 2024

Prohibit placeholders in partial keywords #125028

Closed

📜🤖 Added by blurb_it.

71e65c3

dg-pb mentioned this pull request Oct 28, 2024

functools.partial placeholders #119127

Closed

erlend-aasland reviewed Oct 28, 2024

View reviewed changes

Lib/functools.py Outdated Show resolved Hide resolved

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

no loop for check

294f189

dg-pb marked this pull request as draft October 30, 2024 08:59

bedevere-app bot removed the awaiting review label Oct 30, 2024

dg-pb marked this pull request as ready for review October 30, 2024 10:16

bedevere-app bot added the awaiting review label Oct 30, 2024

zhangyx1998 reviewed Nov 14, 2024

View reviewed changes

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

erlend-aasland reviewed Jan 4, 2025

View reviewed changes

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

dg-pb and others added 2 commits January 5, 2025 10:03

Idiomatic C

5abc61e

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

remove unrelated changes

656361b

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

erlend-aasland reviewed Jan 5, 2025

View reviewed changes

Lib/test/test_functools.py Outdated Show resolved Hide resolved

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

dg-pb and others added 2 commits January 5, 2025 14:56

loosen the regex in test

da4214a

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>

improved error message

26dded8

erlend-aasland requested changes Jan 5, 2025

View reviewed changes

bedevere-app bot added awaiting changes and removed awaiting review labels Jan 5, 2025

doc updates

e8d7521

bedevere-app bot removed the awaiting changes label Jan 5, 2025

bedevere-app bot requested a review from erlend-aasland January 5, 2025 21:40

erlend-aasland approved these changes Jan 5, 2025

View reviewed changes

bedevere-app bot added awaiting merge and removed awaiting change review labels Jan 5, 2025

erlend-aasland requested a review from serhiy-storchaka January 5, 2025 21:45

serhiy-storchaka reviewed Jan 6, 2025

View reviewed changes

Lib/test/test_functools.py Show resolved Hide resolved

Lib/functools.py Outdated Show resolved Hide resolved

Modules/_functoolsmodule.c Show resolved Hide resolved

Modules/_functoolsmodule.c Outdated Show resolved Hide resolved

decouple error checking and kw merging + tests

106e6bc

dg-pb mentioned this pull request Jan 6, 2025

gh-124652: partialmethod simplifications #124788

Open

serhiy-storchaka approved these changes Jan 6, 2025

View reviewed changes

Lib/test/test_functools.py Outdated Show resolved Hide resolved

make test meaningful for ANY check

5e151aa

dg-pb mentioned this pull request Jan 6, 2025

functools.partialmethod simplification #124652

Open

serhiy-storchaka reviewed Jan 7, 2025

View reviewed changes

Lib/test/test_functools.py Outdated Show resolved Hide resolved

Use ALWAYS_EQ instead of ANY

38ff471

serhiy-storchaka reviewed Jan 7, 2025

View reviewed changes

Lib/test/test_functools.py Outdated Show resolved Hide resolved

comment update

85955d6

serhiy-storchaka approved these changes May 8, 2025

View reviewed changes

serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label May 8, 2025

serhiy-storchaka merged commit afed5f8 into python:main May 8, 2025
43 checks passed

bedevere-app bot removed the awaiting merge label May 8, 2025

bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label May 8, 2025

serhiy-storchaka pushed a commit that referenced this pull request May 8, 2025

[3.14] gh-125028: Prohibit placeholders in partial keywords (GH-126062)…

effe8d4

… (GH-133645) (cherry picked from commit afed5f8) Co-authored-by: dgpb <3577712+dg-pb@users.noreply.github.com>

dg-pb deleted the gh-125028-prohibit-kw-placeholders branch May 8, 2025 11:57

Pranjal095 pushed a commit to Pranjal095/cpython that referenced this pull request Jul 12, 2025

pythongh-125028: Prohibit placeholders in partial keywords (pythonGH-…

08acc1f

…126062)

taegyunkim pushed a commit to taegyunkim/cpython that referenced this pull request Aug 4, 2025

pythongh-125028: Prohibit placeholders in partial keywords (pythonGH-…

fc6bac1

…126062)

Uh oh!

Conversation

dg-pb commented Oct 28, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

erlend-aasland left a comment

Choose a reason for hiding this comment

Uh oh!

bedevere-app bot commented Jan 5, 2025

Uh oh!

dg-pb commented Jan 5, 2025

Uh oh!

bedevere-app bot commented Jan 5, 2025

Uh oh!

erlend-aasland commented Jan 5, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dg-pb commented May 8, 2025

Uh oh!

serhiy-storchaka left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miss-islington-app bot commented May 8, 2025

Uh oh!

bedevere-app bot commented May 8, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

dg-pb commented Oct 28, 2024 •

edited

Loading