GH-125868: Fix STORE_ATTR_WITH_HINT specialization#125876
Merged
markshannon merged 5 commits intopython:mainfrom Oct 24, 2024
Merged
GH-125868: Fix STORE_ATTR_WITH_HINT specialization#125876markshannon merged 5 commits intopython:mainfrom
markshannon merged 5 commits intopython:mainfrom
Conversation
Contributor
|
This fixes cython/cython#6426 |
iritkatriel
approved these changes
Oct 24, 2024
hroncok
suggested changes
Oct 24, 2024
Contributor
hroncok
left a comment
hroncok
left a comment
There was a problem hiding this comment.
The versions in NEWS are off by one.
Misc/NEWS.d/next/Core_and_Builtins/2024-10-23-14-05-47.gh-issue-125868.uLfXYB.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core_and_Builtins/2024-10-23-14-05-47.gh-issue-125868.uLfXYB.rst
Outdated
Show resolved
Hide resolved
Co-authored-by: Miro Hrončok <miro@hroncok.cz>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix, but challenging to test.
Also fixes a minor bug I found in
dis.dis(show_caches=True)while investigating the issue.None#125868