Skip to content

gh-122546: Relax SyntaxError check when raising errors on the new REPL#123233

Merged
pablogsal merged 1 commit intopython:mainfrom
skirpichev:exc-subcls-syntaxerr-122546
Aug 22, 2024
Merged

gh-122546: Relax SyntaxError check when raising errors on the new REPL#123233
pablogsal merged 1 commit intopython:mainfrom
skirpichev:exc-subcls-syntaxerr-122546

Conversation

@skirpichev
Copy link
Member

@skirpichev skirpichev commented Aug 22, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Aug 22, 2024
Closed
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Aug 22, 2024
@pablogsal pablogsal changed the title gh-122546: amends 3d7b1a5 (use issubclass) gh-122546: Relax SyntaxError check when raising errors on the new REPL Aug 22, 2024
@pablogsal pablogsal merged commit 4c3f0cb into python:main Aug 22, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 22, 2024

Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 22, 2024

Sorry, @skirpichev and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4c3f0cbeaec0d49212d305618743fabb0e74a696 3.13

@pablogsal pablogsal added needs backport to 3.13 bugs and security fixes and removed needs backport to 3.13 bugs and security fixes labels Aug 22, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 22, 2024

Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app
Copy link

miss-islington-app bot commented Aug 22, 2024

Sorry, @skirpichev and @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 4c3f0cbeaec0d49212d305618743fabb0e74a696 3.13

@bedevere-app
Copy link

bedevere-app bot commented Aug 22, 2024

GH-123246 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 22, 2024
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Aug 22, 2024
@skirpichev @pablogsal
[3.13] pythongh-122546: Relax SyntaxError check when raising errors o…
cb10dd5 
…n the new REPL (pythonGH-123233)

(cherry picked from commit 4c3f0cb)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Aug 23, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Aug 23, 2024

Thanks @skirpichev for the PR, and @pablogsal for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Aug 23, 2024
@skirpichev @miss-islington
pythongh-122546: Relax SyntaxError check when raising errors on the n…
b9e2f89 
…ew REPL (pythonGH-123233)

(cherry picked from commit 4c3f0cb)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Aug 23, 2024

GH-123247 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Aug 23, 2024
pablogsal pushed a commit that referenced this pull request Aug 23, 2024
@miss-islington @skirpichev
[3.13] gh-122546: Relax SyntaxError check when raising errors on the …
fda8aec 
…new REPL (GH-123233) (#123247)

gh-122546: Relax SyntaxError check when raising errors on the new REPL (GH-123233)
(cherry picked from commit 4c3f0cb)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@skirpichev skirpichev deleted the exc-subcls-syntaxerr-122546 branch August 23, 2024 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal pablogsal is a code owner

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

@ambv ambv Awaiting requested review from ambv ambv is a code owner

Assignees

@pablogsal pablogsal

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@skirpichev @picnixz @pablogsal