gh-112301: Add argument aliases and tee compiler output for check warnings#122465
Merged
zware merged 2 commits intopython:mainfrom Jul 30, 2024
Merged
gh-112301: Add argument aliases and tee compiler output for check warnings#122465zware merged 2 commits intopython:mainfrom
zware merged 2 commits intopython:mainfrom
Conversation
Member
|
Thank you for addressing my other review! do you want to address #121730 (comment) as well? (i.e. removing the shebang)? (By the way, thanks for this tool; I was tired of doing it manually) |
picnixz
reviewed
Jul 30, 2024
sethmlarson
approved these changes
Jul 30, 2024
Contributor
sethmlarson
left a comment
sethmlarson
left a comment
There was a problem hiding this comment.
LGTM, makes sense to try to land this one before the others since it impacts compiler outputs for core devs.
Contributor
Author
Removed shebang.
No problem! I am curious what your use case is for running this tool yourself? |
zware
approved these changes
Jul 30, 2024
blhsing
pushed a commit
to blhsing/cpython
that referenced
this pull request
Aug 22, 2024
…ck warnings (pythonGH-122465) Also remove superfluous shebang from the warning check script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds argument aliases for the
check_warnings.pyscript per suggestions: #121730 (comment)Also includes re-adding compiler output to the
build_ubuntujob log using tee as suggested: #121730 (comment)