gh-122237: Fix REPL wrong auto-indentation with comments#122238
Closed
HarryLHW wants to merge 1 commit intopython:mainfrom
Closed
gh-122237: Fix REPL wrong auto-indentation with comments#122238HarryLHW wants to merge 1 commit intopython:mainfrom
HarryLHW wants to merge 1 commit intopython:mainfrom
Conversation
Contributor
Author
|
At this point, it will never auto-indent if there is only a comment without other code in the last line. This will produce the following situation, and I am trying to fix that if possible. |
Contributor
For what it’s worth, I’m not sure I would consider this a bug. Presumably, the user had to un-indent the comment line deliberately, so I would expect the following line to also be un-indented, if that makes sense. Are there other situations where this behavior leads to incorrect indentation? |
Contributor
|
This is fixed already. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.