Skip to content

gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0).#119591

Merged
jaraco merged 2 commits intopython:mainfrom
jaraco:zipfile-is-symlink
Jun 3, 2024
Merged

gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0).#119591
jaraco merged 2 commits intopython:mainfrom
jaraco:zipfile-is-symlink

Conversation

@jaraco
Copy link
Member

@jaraco jaraco commented May 27, 2024 •
edited by bedevere-app bot
Loading

@jaraco jaraco added needs backport to 3.12 only security fixes needs backport to 3.13 bugs and security fixes labels May 27, 2024
@bedevere-app bedevere-app bot mentioned this pull request May 27, 2024
Closed
@jaraco jaraco requested a review from Yhg1s May 27, 2024 01:53
@jaraco
Copy link
Member Author

jaraco commented May 27, 2024 •
edited
Loading

@Yhg1s - I've tagged you on the review as I'd like your opinion on whether this qualifies as a bugfix for Python 3.12. It's considered a security issue by some (that's how it was reported to me), but since the issue was introduced in 3.12, there's no need to backport it to security-only Pythons.

Are you okay with including this change as a bugfix for Python 3.12 (and by extension 3.13), or would you rather keep the "always false" behavior for 3.12 and 3.13?

@jaraco jaraco merged commit 42a34dd into python:main Jun 3, 2024
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 3, 2024

Thanks @jaraco for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13.
🐍🍒⛏🤖

@jaraco jaraco deleted the zipfile-is-symlink branch June 3, 2024 15:13
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 3, 2024
@jaraco @miss-islington
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
094c41e 
…thonGH-119591)

(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
@miss-islington-app
Copy link

miss-islington-app bot commented Jun 3, 2024

Sorry, @jaraco, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 42a34ddb0b63e638905b01e17a7254623a0de427 3.12

@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2024

GH-119985 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jun 3, 2024
@bedevere-app
Copy link

bedevere-app bot commented Jun 3, 2024

GH-119988 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 only security fixes label Jun 3, 2024
mliezun pushed a commit to mliezun/cpython that referenced this pull request Jun 3, 2024
@jaraco @mliezun
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
578b6ce 
…thon#119591)
jaraco added a commit that referenced this pull request Jun 4, 2024
@miss-islington @jaraco
[3.13] gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (G…
34a6d89 
…H-119591) (#119985)

gh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (GH-119591)
(cherry picked from commit 42a34dd)

Co-authored-by: Jason R. Coombs <jaraco@jaraco.com>
barneygale pushed a commit to barneygale/cpython that referenced this pull request Jun 5, 2024
@jaraco @barneygale
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
25d0a68 
…thon#119591)
noahbkim pushed a commit to hudson-trading/cpython that referenced this pull request Jul 11, 2024
@jaraco @noahbkim
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
57f461d 
…thon#119591)
estyxx pushed a commit to estyxx/cpython that referenced this pull request Jul 17, 2024
@jaraco @estyxx
pythongh-119588: Implement zipfile.Path.is_symlink (zipp 3.19.0). (py…
dd2c3f3 
…thon#119591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yhg1s Yhg1s Awaiting requested review from Yhg1s

Assignees

@jaraco jaraco

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@jaraco