GH-118447: Fix handling of unreadable symlinks in os.path.realpath()#118489
Merged
barneygale merged 8 commits intopython:mainfrom May 18, 2024
Merged
GH-118447: Fix handling of unreadable symlinks in os.path.realpath()#118489barneygale merged 8 commits intopython:mainfrom
os.path.realpath()#118489barneygale merged 8 commits intopython:mainfrom
Conversation
barneygale
changed the title
os.path.realpath()os.path.realpath()
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Contributor
Author
|
nineteendo
reviewed
May 9, 2024
Contributor
nineteendo
left a comment
nineteendo
left a comment
There was a problem hiding this comment.
OK, you're right, it shouldn't raise an error. That's what strict is for.
Member
|
I think that it is reasonable to expect that |
nineteendo
approved these changes
May 18, 2024
Contributor
nineteendo
left a comment
nineteendo
left a comment
There was a problem hiding this comment.
Barney, would you like to continue working on this? You have my approval if it means anything.
barneygale
added
needs backport to 3.12
Contributor
Author
|
Thanks for the reviews and suggestions, both! |
|
Thanks @barneygale for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12, 3.13. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 18, 2024
…path()` (pythonGH-118489) (cherry picked from commit caf6064) Co-authored-by: Barney Gale <[email protected]> Co-authored-by: Nice Zombies <[email protected]>
|
Sorry, @barneygale, I could not cleanly backport this to |
|
GH-119163 is a backport of this pull request to the 3.13 branch. |
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
May 18, 2024
…path()` (python#118489) Co-authored-by: Nice Zombies <[email protected]> (cherry picked from commit caf6064)
barneygale
added a commit
to barneygale/cpython
that referenced
this pull request
May 18, 2024
…th.realpath()` (pythonGH-118489) Co-authored-by: Nice Zombies <[email protected]>. (cherry picked from commit caf6064) Co-authored-by: Barney Gale <[email protected]>
Contributor
Author
|
If no one objects, I'll skip backporting to 3.12 as this is a fairly minor bug and I can't be bothered to fix the conflicts :) |
|
|
barneygale
added a commit
that referenced
this pull request
May 18, 2024
…lpath()` (GH-118489) (#119163) (cherry picked from commit caf6064) Co-authored-by: Barney Gale <[email protected]> Co-authored-by: Nice Zombies <[email protected]>
|
|
estyxx
pushed a commit
to estyxx/cpython
that referenced
this pull request
Jul 17, 2024
…path()` (python#118489) Co-authored-by: Nice Zombies <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
posixpath.realpath('secretlink')raises #118447