gh-115124: Use _PyObject_ASSERT() in gc.c#115125
Merged
vstinner merged 1 commit intopython:mainfrom Feb 15, 2024
Merged
Conversation
Member
Author
|
!buildbot Windows11 Bigmem |
Member
Author
Member
Author
|
AMD64 Windows11 Bigmem PR job: https://buildbot.python.org/all/#/builders/1088/builds/308 |
vstinner
force-pushed
the
gc_assert
branch
2 times, most recently
from
2b625c7 to
3f8a768
Compare
Member
Author
|
@pablogsal: I rebased my PR. Would you mind to review the change? |
Member
Author
|
@colesbury @nascheme: Would you mind to review this change? |
colesbury
approved these changes
Feb 15, 2024
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
There's a compiler warning, but otherwise LGTM
Python/gc.c
Outdated
| next isn't, so they can't | ||
| be the same */ | ||
| // wrasgc is reachable, but next isn't, so they can't be the same | ||
| _PyObject_ASSERT(wr, wrasgc != next); |
Contributor
There was a problem hiding this comment.
There's a GitHub actions warning: I think this needs a (PyObject *) cast on wr.
Member
Author
There was a problem hiding this comment.
Alright, I missed that warning. It's now fixed.
pablogsal
approved these changes
Feb 15, 2024
Member
pablogsal
left a comment
pablogsal
left a comment
There was a problem hiding this comment.
LGTM modulo the compiler warning
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
Member
Author
|
@colesbury @pablogsal: Thanks for reviews. I rebased my PR on main, fixed the compiler warning, and enabled "auto-merge". |
diegorusso
pushed a commit
to diegorusso/cpython
that referenced
this pull request
Apr 17, 2024
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
LukasWoodtli
pushed a commit
to LukasWoodtli/cpython
that referenced
this pull request
Jan 22, 2025
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace assert() with _PyObject_ASSERT() in gc.c to dump the object when an assertion fails.