gh-103323: Remove current_fast_get() unused parameter#114593
Merged
vstinner merged 1 commit intopython:mainfrom Jan 30, 2024
Merged
gh-103323: Remove current_fast_get() unused parameter#114593vstinner merged 1 commit intopython:mainfrom
vstinner merged 1 commit intopython:mainfrom
Conversation
The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.
Member
Author
|
@ericsnowcurrently @colesbury @corona10: Would you mind to review this change? The change commit f8abfa3 modified current_fast_get(). Before the Python Thread State was retrieved from runtime, but it's no longer the case. |
ericsnowcurrently
approved these changes
Jan 26, 2024
Member
ericsnowcurrently
left a comment
ericsnowcurrently
left a comment
There was a problem hiding this comment.
LGTM
IIRC, the main reason I left the parameter was to reduce churn. After that I didn't see any harm in leaving the parameter. That said, I'm not opposed to dropping it.
colesbury
approved these changes
Jan 26, 2024
Contributor
colesbury
left a comment
colesbury
left a comment
There was a problem hiding this comment.
This looks more straightforward to me too
Member
Author
|
Merged, thanks for reviews. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
…14593) The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current_fast_get() static inline function doesn't use its 'runtime' parameter, so just remove it.