gh-111460: restore ncurses widechar support on macOS#111878
Merged
corona10 merged 1 commit intopython:mainfrom Nov 13, 2023
Merged
gh-111460: restore ncurses widechar support on macOS#111878corona10 merged 1 commit intopython:mainfrom
corona10 merged 1 commit intopython:mainfrom
Conversation
Contributor
|
Do you have the bandwidth to review this, @corona10? |
Member
|
This weekend I will try :) |
corona10
approved these changes
Nov 13, 2023
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Nov 13, 2023
…111878) (cherry picked from commit d2f305d) Co-authored-by: Davide Rizzo <[email protected]>
|
GH-112034 is a backport of this pull request to the 3.12 branch. |
|
Might it be that a similar fix needs to be applied to the following line: Line 6265 in f497525 It seems to me like this check is equally broken. |
Contributor
Please open a new issue for this. |
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ncurses wide character support on macOS was broken as an unintended consequence of #94452. It is now built as intended.