Closed
Conversation
AlexWaygood
reviewed
Oct 25, 2023
Member
AlexWaygood
left a comment
AlexWaygood
left a comment
There was a problem hiding this comment.
This LGTM, I'm in favour. As with #110917, though, I think maybe we should hold off here until we've posted on Discourse to check that others are okay with having more lints in CPython's CI. (I haven't got round to doing that post yet.) It's possible this and #110917 could be disruptive to people's workflows if they aren't familiar with ruff and/or pre-commit, so it would be good to give people a chance to voice their objections before going ahead with this. I'm in the pro-linter camp, but different people have different opinions on the usefulness of linters
Member
Author
|
Superseded by #122018. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is with the default checks. Not too many changes needed!
What do you think, is that okay or should we specify some?
📚 Documentation preview 📚: https://cpython-previews--111192.org.readthedocs.build/